[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 07:20:31 PDT 2020


sstefan1 added a comment.

In D86021#2303405 <https://reviews.llvm.org/D86021#2303405>, @nikic wrote:

> I find the naming here confusing: Looking at this patch my expectation was that `DefaultIntrinsic` is used for intrinsics with default attributes, based on the name. Took me a while to understand it's actually the other way around. Shouldn't the Intrinsic <-> DefaultIntrinsic naming be inverted?

I agree that it is not perfect. TBH that is one of the reasons for coro intrinsics confusion. I think there would always be some level of confusion between the two. Does `OptOutIntrinsic` sound better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86021/new/

https://reviews.llvm.org/D86021



More information about the llvm-commits mailing list