[PATCH] D86021: [IR] Make nosync, nofree and willreturn default for intrinsics.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 30 07:18:49 PDT 2020


jdoerfert added a comment.

In D86021#2303405 <https://reviews.llvm.org/D86021#2303405>, @nikic wrote:

> I find the naming here confusing: Looking at this patch my expectation was that `DefaultIntrinsic` is used for intrinsics with default attributes, based on the name. Took me a while to understand it's actually the other way around. Shouldn't the Intrinsic <-> DefaultIntrinsic naming be inverted?

Possible, that will make it "opt-in" for existing intrinsics again. I'm fine with either. Alternative names for this scheme:

DefaultIntrinsic -> ExplicitAttrIntrinsic?
DefaultIntrinsic -> ConservativeIntrinsic?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86021/new/

https://reviews.llvm.org/D86021



More information about the llvm-commits mailing list