[PATCH] D88419: [RDA] Switch isSafeToMove iterators

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/mov-operand.ll:31
 ; CHECK-NEXT:    vadd.f32 s0, s3, s3
+; CHECK-NEXT:    mov r3, r1
 ; CHECK-NEXT:    vcvt.f32.u32 s4, s4
----------------
samtebbs wrote:
> I may be misunderstanding this but won't this overwrite the subtraction to r3 that is done each iteration? So I think this should be outside the loop like it was before.
The DLS doesn't actually signal the beginning on the loop, and the mov is still in the preheader. The loop body begins with the vctp.32.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88419/new/

https://reviews.llvm.org/D88419