[PATCH] D88419: [RDA] Switch isSafeToMove iterators

Sam Tebbs via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 28 08:54:33 PDT 2020


samtebbs added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/mov-operand.ll:31
 ; CHECK-NEXT:    vadd.f32 s0, s3, s3
+; CHECK-NEXT:    mov r3, r1
 ; CHECK-NEXT:    vcvt.f32.u32 s4, s4
----------------
I may be misunderstanding this but won't this overwrite the subtraction to r3 that is done each iteration? So I think this should be outside the loop like it was before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88419/new/

https://reviews.llvm.org/D88419



More information about the llvm-commits mailing list