[PATCH] D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation
Dominic Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 28 10:54:31 PDT 2020
ddcc marked an inline comment as done.
ddcc added inline comments.
================
Comment at: llvm/test/Instrumentation/AddressSanitizer/debug_info.ll:10
+ at G = global [32 x i8] zeroinitializer, align 32, !dbg !0, !type !6
+; CHECK: @G = global { [32 x i8], [32 x i8] } zeroinitializer{{(, comdat)?}}, align 32, !dbg !0, !type !6
+
----------------
aprantl wrote:
> Can you try to not hardcode !6 and instead use a placeholder like `[[TYPE:[0-9]+]]` and add a second CHECK for [[TYPE]] = ...?
Ok, will do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88368/new/
https://reviews.llvm.org/D88368
More information about the llvm-commits
mailing list