[PATCH] D88368: [AddressSanitizer] Copy type metadata to prevent miscompilation

Mon Sep 28 09:12:05 PDT 2020

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/test/Instrumentation/AddressSanitizer/debug_info.ll:10
+ at G = global [32 x i8] zeroinitializer, align 32, !dbg !0, !type !6
+; CHECK: @G = global { [32 x i8], [32 x i8] } zeroinitializer{{(, comdat)?}}, align 32, !dbg !0, !type !6
+
----------------
Can you try to not hardcode !6 and instead use a placeholder like `[[TYPE:[0-9]+]]` and add a second CHECK for [[TYPE]] = ...?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88368/new/

https://reviews.llvm.org/D88368