[PATCH] D88305: [COFF] Aliases resolve directly to defined external targets

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:359
+  else
     return nullptr;
 }
----------------
Can you come up with a scenario where you hit this else/return nullptr? Because in all of my testcases, I either hit the "return GetOr...", or return early at the first check (!Symbol.isVariable()).

I.e. it's hard to get a feel for whether this is the right condition here, as long as one could just as well remove the if statement altogether.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88305/new/

https://reviews.llvm.org/D88305