[PATCH] D88305: [COFF] Aliases resolve directly to defined external targets

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

I tested this with an input file like this here:

          .globl uniquename
  uniquename:
          ret
  
          .globl weakundef
  
          .globl func
  func:
          call weakundef
          ret
  
          .weak aliasname
  aliasname = func
  
          .weak secondalias
  secondalias = aliasname
  
          .weak weakundef
  
          .weak weakfunc 
          .globl weakfunc
  weakfunc:
          ret
  
          .weak undefalias
  undefalias = undefsym

Maybe it'd be good to add more testcases out of these, in addition to the one added here (with verbose comments in the testcase about what's tested and what the expected outcome is), if some of the cases aren't exercised by the current tests. At least the second-level alias and alias against an undefined symbol (`undefalias`) are untested I think, and I don't see a case that really matches the `weakfunc` case either - so it'd be good to have those covered as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88305/new/

https://reviews.llvm.org/D88305