[PATCH] D88310: [CMake][AIX] Limit tools in external project build
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 25 13:12:24 PDT 2020
daltenty updated this revision to Diff 294410.
daltenty added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88310/new/
https://reviews.llvm.org/D88310
Files:
llvm/cmake/modules/LLVMExternalProjectUtils.cmake
Index: llvm/cmake/modules/LLVMExternalProjectUtils.cmake
===================================================================
--- llvm/cmake/modules/LLVMExternalProjectUtils.cmake
+++ llvm/cmake/modules/LLVMExternalProjectUtils.cmake
@@ -53,14 +53,18 @@
endforeach()
if(NOT ARG_TOOLCHAIN_TOOLS)
- set(ARG_TOOLCHAIN_TOOLS clang lld llvm-ar llvm-ranlib llvm-nm llvm-objdump)
- if(_cmake_system_name STREQUAL Darwin)
- list(APPEND ARG_TOOLCHAIN_TOOLS llvm-libtool-darwin llvm-lipo)
- elseif(_cmake_system_name STREQUAL Windows)
- list(APPEND ARG_TOOLCHAIN_TOOLS llvm-lib)
- else()
- # TODO: These tools don't fully support Mach-O format yet.
- list(APPEND ARG_TOOLCHAIN_TOOLS llvm-objcopy llvm-strip)
+ set(ARG_TOOLCHAIN_TOOLS clang)
+ # AIX 64-bit XCOFF and big AR format is not yet supported in some of these tools.
+ if(NOT _cmake_system_name STREQUAL AIX)
+ list(APPEND ARG_TOOLCHAIN_TOOLS lld llvm-ar llvm-lipo llvm-ranlib llvm-nm llvm-objdump)
+ if(_cmake_system_name STREQUAL Darwin)
+ list(APPEND ARG_TOOLCHAIN_TOOLS llvm-libtool-darwin llvm-lipo)
+ elseif(_cmake_system_name STREQUAL Windows)
+ list(APPEND ARG_TOOLCHAIN_TOOLS llvm-lib)
+ else()
+ # TODO: These tools don't fully support Mach-O format yet.
+ list(APPEND ARG_TOOLCHAIN_TOOLS llvm-objcopy llvm-strip)
+ endif()
endif()
endif()
foreach(tool ${ARG_TOOLCHAIN_TOOLS})
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88310.294410.patch
Type: text/x-patch
Size: 1447 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200925/0ee2e2e5/attachment.bin>
More information about the llvm-commits
mailing list