[PATCH] D88310: [CMake][AIX] Limit tools in external project build

[Steven Wan via Phabricator via llvm-commits]

stevewan added inline comments.


================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:57
+    set(ARG_TOOLCHAIN_TOOLS clang)
+    # 64-bit XCOFF and big AR format is not yet supported in some of these tools.
+    if(NOT _cmake_system_name MATCHES AIX)
----------------
Minor nit: While it is clear given the context, can we also be explicit in the comment that 64-bit XCOFF and big AR format is an AIX thing?


================
Comment at: llvm/cmake/modules/LLVMExternalProjectUtils.cmake:58
+    # 64-bit XCOFF and big AR format is not yet supported in some of these tools.
+    if(NOT _cmake_system_name MATCHES AIX)
+      list(APPEND ARG_TOOLCHAIN_TOOLS lld llvm-ar llvm-lipo llvm-ranlib llvm-nm llvm-objdump)
----------------
Let's also use STREQUAL here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88310/new/

https://reviews.llvm.org/D88310