[PATCH] D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport
Zequan Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 23 16:08:10 PDT 2020
zequanwu added a comment.
In D88127#2291167 <https://reviews.llvm.org/D88127#2291167>, @rnk wrote:
> However, I would prefer to move the check into CodeGen, so that if we receive some IR that has edges like this, we don't emit an object file that cannot be linked.
I think we just want to do it here, simply don't generate the "CG Profile" metadata entry for dllimport function, since the IR could complied to assembly or object file. Otherwise, we need two checks in both MCAsmStreamer and MCCOFFStreamer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88127/new/
https://reviews.llvm.org/D88127
More information about the llvm-commits
mailing list