[PATCH] D88127: [CGProfile] don't emit cgprofile entry if called function is dllimport
    Reid Kleckner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Wed Sep 23 15:12:48 PDT 2020
    
    
  
rnk added a comment.
I think this is reasonable. There is no need to record call graph profile edges from functions to imported functions in the metadata. However, I would prefer to move the check into CodeGen, so that if we receive some IR that has edges like this, we don't emit an object file that cannot be linked. I'd be OK doing the check in both places.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88127/new/
https://reviews.llvm.org/D88127
    
    
More information about the llvm-commits
mailing list