[PATCH] D84287: [SelectionDAG][GISel] Make LegalizeDAG lower FNEG using integer ops.

Wed Sep 23 12:12:12 PDT 2020

efriedma added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMLegalizerInfo.cpp:91
       .legalFor({s32})
-      .minScalar(0, s32);
+      .clampScalar(0, s32, s32);

----------------
RKSimon wrote:
> should this be a separate fix?
The tests in this patch exercise this codepath.  I guess it could also be tested independently; I'll look at adding a few more tests.

================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-fneg.mir:2
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -O0 -run-pass=legalizer %s -o - | FileCheck %s

----------------
RKSimon wrote:
> Worth adding a f80 case as well?
f80 currently isn't supported by GlobalISel.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84287/new/

https://reviews.llvm.org/D84287