[PATCH] D84287: [SelectionDAG][GISel] Make LegalizeDAG lower FNEG using integer ops.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 02:17:45 PDT 2020


RKSimon added a reviewer: spatel.
RKSimon added a comment.

@arsenm Any more thoughts?



================
Comment at: llvm/lib/Target/ARM/ARMLegalizerInfo.cpp:91
       .legalFor({s32})
-      .minScalar(0, s32);
+      .clampScalar(0, s32, s32);
 
----------------
should this be a separate fix?


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-fneg.mir:2
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -O0 -run-pass=legalizer %s -o - | FileCheck %s
 
----------------
Worth adding a f80 case as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84287/new/

https://reviews.llvm.org/D84287



More information about the llvm-commits mailing list