[PATCH] D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 23 01:53:32 PDT 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:638
+##                                                       ^--- file length (ULEB128) 0x1234
+# EXTLEN-NEXT: 0x00000020 00b42401
+##                        ^-                                  DW_LNS_extended_op
----------------
Thinking about it, I guess we need something on this line to show that we've reached the end of the content (i.e. to show we haven't written any bogus extra data). Maybe something as simple as `{{  }}` (with more than one space). Other ideas also welcome.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88136/new/

https://reviews.llvm.org/D88136



More information about the llvm-commits mailing list