[PATCH] D88136: [DWARFYAML] Make the ExtLen field of extended opcodes optional.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:627
+#      EXTLEN: Hex dump of section '.debug_line':
+# EXTLEN-NEXT: 0x00000000 20000000 04000800 00000101 01fb0e01  ...............
+##                        ^-------                            unit_length (4-byte)
----------------
jhenderson wrote:
> Something's not quite right at the end of this number sequence, the dots don't line up with the words beneath. Do you actually need the dots?
`0x20` is `<SPC>`. Hence, the number of dots on the right side is 15 (16 - 1). I think we don't actually need them.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-line.yaml:628-636
+##                        ^-------                            unit_length (4-byte)
+##                                 ^---                       version (2-byte)
+##                                     ^--------              header_length (4-byte)
+##                                              ^-            minimum_instruction_length (1-byte)
+##                                                ^-          maximum_operations_per_instruction (1-byte)
+##                                                   ^-       default_is_stmt (1-byte)
+##                                                     ^-     line_base (1-byte)
----------------
jhenderson wrote:
> Where you're not interested in the header, maybe we could simplify this to just say something like `^------------------------ header`?
Good idea!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88136/new/

https://reviews.llvm.org/D88136