[PATCH] D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 11:42:54 PDT 2020


rnk added a comment.

Seems reasonable, if the new multi-value phi works with later passes.



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1145
+  // cleanuppad.corodispatch
+  //    %2 = phi i8[0, %catchswitch], [1, %catch.1]
+  //    %3 = cleanuppad within none []
----------------
Isn't this still a multi-valued phi node? Is it OK because it has constant arguments?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88059/new/

https://reviews.llvm.org/D88059



More information about the llvm-commits mailing list