[PATCH] D88059: [Coroutine] Split PHI Nodes in `cleanuppad` blocks in a way that obeys EH pad rules
Xun Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 22 11:30:41 PDT 2020
lxfind added inline comments.
================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1211
+ if (auto *CatchSwitch = dyn_cast<CatchSwitchInst>(Pred->getTerminator())) {
+ return CatchSwitch->getUnwindDest() == BB;
+ }
----------------
Should this be
```
if (CatchSwitch->getUnwindDest() == BB)
return true;
```
?
Or is it impossible to have multiple predecessors with `CatchSwitch` all pointing to BB somehow?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88059/new/
https://reviews.llvm.org/D88059
More information about the llvm-commits
mailing list