[PATCH] D84419: Fix interaction between stack alignment and inline-asm stack clash protection

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 10:52:29 PDT 2020


efriedma added a comment.

> I think this adresses @efriedma comment (?)

Maybe?  I'd like to make sure we have test coverage for:

- the case where alignment+offset is less than the probe size
- the case where both alignment and offset are less than the probe size, but align+offset is greater than the probe size

(In stack-clash-small-alloc-medium-align.ll, it looks like alignment+offset is exactly equal to the probe size?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84419/new/

https://reviews.llvm.org/D84419



More information about the llvm-commits mailing list