[PATCH] D84419: Fix interaction between stack alignment and inline-asm stack clash protection

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 22 08:53:20 PDT 2020


serge-sans-paille updated this revision to Diff 293475.
serge-sans-paille added a comment.

Enforce an extra invariant: after alignment adjustment, there is less than PAGE_SIZE unprobed, which make sit possible to decouple it from stack allocation probing. I think this adresses @efriedma comment (?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84419/new/

https://reviews.llvm.org/D84419

Files:
  llvm/lib/Target/X86/X86FrameLowering.cpp
  llvm/lib/Target/X86/X86FrameLowering.h
  llvm/test/CodeGen/X86/stack-clash-large-large-align.ll
  llvm/test/CodeGen/X86/stack-clash-no-free-probe.ll
  llvm/test/CodeGen/X86/stack-clash-small-alloc-medium-align.ll
  llvm/test/CodeGen/X86/stack-clash-small-large-align.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84419.293475.patch
Type: text/x-patch
Size: 21071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200922/08bd6939/attachment.bin>


More information about the llvm-commits mailing list