[PATCH] D88016: [llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 21 05:38:49 PDT 2020
grimar added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1190-1193
Elf_Sym_Range Syms = unwrapOrError(
ObjF->getFileName(), ObjF->getELFFile()->symbols(DotSymtabSec));
Expected<unsigned> SectionIndex =
+ getSymbolSectionIndex(Symbol, Symbol - Syms.begin());
----------------
jhenderson wrote:
> This is assuming the symbol is from the .symtab symbol table. I seem to remember you are fixing that elsewhere?
Yep. Here: D87899
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88016/new/
https://reviews.llvm.org/D88016
More information about the llvm-commits
mailing list