[PATCH] D88016: [llvm-readobj/libObject] - Get rid of `FirstSym` argument. NFCI.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 21 05:37:28 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, assuming I'm not mistaken in thinking there's another patch related to this one.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1190-1193
     Elf_Sym_Range Syms = unwrapOrError(
         ObjF->getFileName(), ObjF->getELFFile()->symbols(DotSymtabSec));
     Expected<unsigned> SectionIndex =
+        getSymbolSectionIndex(Symbol, Symbol - Syms.begin());
----------------
This is assuming the symbol is from the .symtab symbol table. I seem to remember you are fixing that elsewhere?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88016/new/

https://reviews.llvm.org/D88016



More information about the llvm-commits mailing list