[PATCH] D87667: [Support/Path] Add path::is_gnu_absolute

[Vinicius Tinti via Phabricator via llvm-commits]

tinti updated this revision to Diff 293132.
tinti marked 7 inline comments as done.
tinti retitled this revision from "[Support/Path] Add path::is_gnu_style_absolute" to "[Support/Path] Add path::is_gnu_absolute".
tinti edited the summary of this revision.
tinti added a comment.

- Drop the "_style" in the name of the function.
- Add ":" test.
- Add comment about LLVM is_absolute.
- Add Vector constructor.

Now I think it is better to call it "is_gnu_absolute". The "style" is already used for style::{posix,windows,native}.
After reading the comments it was confusing. It might sound like we were introducing a new style::gnu which is not the case.

I can revert back if you don't agree. Please let me know.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87667/new/

https://reviews.llvm.org/D87667

Files:
  llvm/include/llvm/Support/Path.h
  llvm/lib/Support/Path.cpp
  llvm/unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87667.293132.patch
Type: text/x-patch
Size: 3731 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200921/647515d3/attachment.bin>