[llvm] 58ecbbc - [X86] Fix copy paste mistake in @ccnp flag.

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 21:53:55 PDT 2020


Author: Craig Topper
Date: 2020-09-18T21:28:01-07:00
New Revision: 58ecbbcdcddf80b289c449b86d5996d58fba0d78

URL: https://github.com/llvm/llvm-project/commit/58ecbbcdcddf80b289c449b86d5996d58fba0d78
DIFF: https://github.com/llvm/llvm-project/commit/58ecbbcdcddf80b289c449b86d5996d58fba0d78.diff

LOG: [X86] Fix copy paste mistake in @ccnp flag.

We were treating @ccp and @ccnp the same.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp
    llvm/test/CodeGen/X86/inline-asm-flag-output.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 5ec814ba61c1..2070517f1e85 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -49954,7 +49954,7 @@ static X86::CondCode parseConstraintCode(llvm::StringRef Constraint) {
                            .Case("{@ccnl}", X86::COND_GE)
                            .Case("{@ccnle}", X86::COND_G)
                            .Case("{@ccno}", X86::COND_NO)
-                           .Case("{@ccnp}", X86::COND_P)
+                           .Case("{@ccnp}", X86::COND_NP)
                            .Case("{@ccns}", X86::COND_NS)
                            .Case("{@cco}", X86::COND_O)
                            .Case("{@ccp}", X86::COND_P)

diff  --git a/llvm/test/CodeGen/X86/inline-asm-flag-output.ll b/llvm/test/CodeGen/X86/inline-asm-flag-output.ll
index af7a437d5965..d9ae4f8d2027 100644
--- a/llvm/test/CodeGen/X86/inline-asm-flag-output.ll
+++ b/llvm/test/CodeGen/X86/inline-asm-flag-output.ll
@@ -726,7 +726,7 @@ define i32 @test_ccnp(i64 %nr, i64* %addr) nounwind {
 ; X32-NEXT:    #APP
 ; X32-NEXT:    cmp %ecx,(%esi)
 ; X32-NEXT:    #NO_APP
-; X32-NEXT:    setp %al
+; X32-NEXT:    setnp %al
 ; X32-NEXT:    popl %esi
 ; X32-NEXT:    retl
 ;
@@ -736,7 +736,7 @@ define i32 @test_ccnp(i64 %nr, i64* %addr) nounwind {
 ; X64-NEXT:    #APP
 ; X64-NEXT:    cmp %rdi,(%rsi)
 ; X64-NEXT:    #NO_APP
-; X64-NEXT:    setp %al
+; X64-NEXT:    setnp %al
 ; X64-NEXT:    retq
 entry:
   %cc = tail call i32 asm "cmp $2,$1", "={@ccnp},=*m,r,~{cc},~{dirflag},~{fpsr},~{flags}"(i64* %addr, i64 %nr) nounwind


        


More information about the llvm-commits mailing list