[PATCH] D87746: [mlir] Fix of updating function signature in normalizing memrefs

Haruki Imai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 15:31:27 PDT 2020


imaihal marked an inline comment as done.
imaihal added inline comments.


================
Comment at: mlir/test/lib/Dialect/Test/TestOps.td:631
 
+// Test for memrefs normalization of an op with a reference to a function
+// symbol.
----------------
AlexEichenberger wrote:
> @imaihal Please add the period.
@AlexEichenberger This is a two line-comment. Is it ok as it is? 

```
// Test for memrefs normalization of an op with a reference to a function
// symbol.
```

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87746/new/

https://reviews.llvm.org/D87746



More information about the llvm-commits mailing list