[PATCH] D87746: [mlir] Fix of updating function signature in normalizing memrefs

Alexandre Eichenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 10:29:22 PDT 2020


AlexEichenberger added a comment.

@imaihal Thanks for the upgrade. Minor nit still remains, please fix.



================
Comment at: mlir/test/lib/Dialect/Test/TestOps.td:631
 
+// Test for memrefs normalization of an op with a reference to a function
+// symbol.
----------------
@imaihal Please add the period.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87746/new/

https://reviews.llvm.org/D87746



More information about the llvm-commits mailing list