[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 18 08:44:24 PDT 2020


amyk added a comment.

Please address clang-format issues and Lei's comments. Other than that, I think the patch LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/vec_cmpq.ll:14
+; CHECK-LABEL: v1si128_cmp:
+; CHECK: vcmpequq 2, 2, 3
+}
----------------
lei wrote:
> please add the check for end of function.. eg `// CHECK: ret <1 x i128>`
I think a check at the end of the function is a good idea. Probably like,
```
; CHECK: blr
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87804/new/

https://reviews.llvm.org/D87804



More information about the llvm-commits mailing list