[PATCH] D87804: [PowerPC][Power10] Implement Vector signed/unsigned __int128 overloads for the comparison builtins

[Lei Huang via Phabricator via llvm-commits]

lei added a comment.

please fix the clang format issues.



================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:365
+  def int_ppc_altivec_vcmpequq : GCCBuiltin<"__builtin_altivec_vcmpequq">,
+               Intrinsic<[llvm_v1i128_ty], [llvm_v1i128_ty, llvm_v1i128_ty],
+                         [IntrNoMem]>;
----------------
nit: indentation


================
Comment at: llvm/test/CodeGen/PowerPC/vec_cmpq.ll:14
+; CHECK-LABEL: v1si128_cmp:
+; CHECK: vcmpequq 2, 2, 3
+}
----------------
please add the check for end of function.. eg `// CHECK: ret <1 x i128>`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87804/new/

https://reviews.llvm.org/D87804