[PATCH] D72148: [DSE] Support traversing MemoryPhis.

Fri Sep 18 05:53:13 PDT 2020

fhahn added a comment.

In D72148#2242386 <https://reviews.llvm.org/D72148#2242386>, @fhahn wrote:

> In D72148#2242301 <https://reviews.llvm.org/D72148#2242301>, @ebrevnov wrote:
>
>>> I won't have time to look into this in the near future unfortunately, as I am mainly focused on getting things in good shape to enable DSE & MemorySSA by default. It might be good to file a bug report so this opportunity does not drop off our radar. If anyone is interested in giving implementing it a try, even better :)
>>
>> Florian, thank you for quick feedback. I prototyped phi translation approach and it does work on the posted test case. Unfortunately, it fails on a bit more complicated case which I will take a look tomorrow. If I have something working reasonably well in the end I will share it.
>
> That's great! There are some changes to how we find MemoryDefs that may be killed by a killing def, rGe717fdb0f155 <https://reviews.llvm.org/rGe717fdb0f155deaa03eaae891bd34743e6ffcb64> and D86487 <https://reviews.llvm.org/D86487>. This might actually make things a bit easier, as we now fully control the traversal of the defining accesses.

Hi @ebrevnov,

I just wanted to briefly check in to see if you made any progress on this or if you think it is worth adding a bug report to keep track of the improvement?

Cheers,
Florian

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72148/new/

https://reviews.llvm.org/D72148