[PATCH] D73739: Exception support for basic block sections

Di Mo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 17 10:57:59 PDT 2020


modimo added a comment.

In D73739#2278496 <https://reviews.llvm.org/D73739#2278496>, @rahmanl wrote:

> Although I can definitely work with you to diagnose any potential issues on ARM64, I suggest we don't write tests for this patch before the base feature is well-tested.
> (On related note, a recent commit (rG157cd93b48a9 <https://reviews.llvm.org/rG157cd93b48a90f484e9eb2ed9997e0372b9c7ebb>) limited -fbasic-block-sections to X86.).

Great, that exact change was what I was going to suggest if tests were not added. Thanks for the link!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739



More information about the llvm-commits mailing list