[PATCH] D73739: Exception support for basic block sections

Wed Sep 16 23:25:28 PDT 2020

rahmanl marked 5 inline comments as done.
rahmanl added a comment.

In D73739#2278247 <https://reviews.llvm.org/D73739#2278247>, @modimo wrote:

> @rahmanl Have you had a chance to run your added test on ARM64 as another itanium C++ ABI target to make sure it works properly? Having testing there is fine as a follow-up but wanted to make sure we're in agreement here. Otherwise changes LGTM, please let @MaskRay have a chance to provide any additional feedback.

Thanks @modimo.
This patch relies on basic-block-sections support which is currently only tested on X86 targets (even though it might work on other targets too). 
Although I can definitely work with you to diagnose any potential issues on ARM64, I suggest we don't write tests for this patch before the base feature is well-tested.
(On related note, a recent commit (rG157cd93b48a9 <https://reviews.llvm.org/rG157cd93b48a90f484e9eb2ed9997e0372b9c7ebb>) limited -fbasic-block-sections to X86.).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73739/new/

https://reviews.llvm.org/D73739