[PATCH] D85293: [DebugInfo] Simplify DIEInteger::SizeOf().

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/unittests/CodeGen/DIEHashTest.cpp:34-39
+  void setupTestPrinter() {
+    auto ExpectedTestPrinter = TestAsmPrinter::create(
+        sys::getDefaultTargetTriple(), /*DwarfVersion=*/4, dwarf::DWARF32);
+    ASSERT_THAT_EXPECTED(ExpectedTestPrinter, Succeeded());
+    TestPrinter = std::move(ExpectedTestPrinter.get());
+  }
----------------
ikudrin wrote:
> dblaikie wrote:
> > I'd probably roll this into getAsmPrinter - but up to you.
> `ASSERT_THAT_EXPECTED` breaks compilation if placed in a non-void function.
Fair enough - seems a bit subtle, but I don't have great alternative suggestions. Thanks for explaining!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85293/new/

https://reviews.llvm.org/D85293