[PATCH] D85293: [DebugInfo] Simplify DIEInteger::SizeOf().
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 16 18:58:22 PDT 2020
ikudrin added inline comments.
================
Comment at: llvm/unittests/CodeGen/DIEHashTest.cpp:34-39
+ void setupTestPrinter() {
+ auto ExpectedTestPrinter = TestAsmPrinter::create(
+ sys::getDefaultTargetTriple(), /*DwarfVersion=*/4, dwarf::DWARF32);
+ ASSERT_THAT_EXPECTED(ExpectedTestPrinter, Succeeded());
+ TestPrinter = std::move(ExpectedTestPrinter.get());
+ }
----------------
dblaikie wrote:
> I'd probably roll this into getAsmPrinter - but up to you.
`ASSERT_THAT_EXPECTED` breaks compilation if placed in a non-void function.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85293/new/
https://reviews.llvm.org/D85293
More information about the llvm-commits
mailing list