[PATCH] D86968: [IRSim] Adding IR Instruction Mapper

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 15 10:01:46 PDT 2020


paquette added inline comments.


================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:44
+
+  return true;
+}
----------------
I think this entire function can be:

```
return A.Legal && A.Inst->isSameOperationAs(B.Inst);
```

Because if `A` is legal, and is the same operation as `B`, then `B` must also be legal.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86968/new/

https://reviews.llvm.org/D86968



More information about the llvm-commits mailing list