[PATCH] D86968: [IRSim] Adding IR Instruction Mapper
Jon Roelofs via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 15 09:08:14 PDT 2020
jroelofs added inline comments.
================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:58
+///
+/// Invisible is and Instruction that is included in the similarity
+/// sections, but is not checked for similarity.
----------------
================
Comment at: llvm/include/llvm/Analysis/IRSimilarityIdentifier.h:267
+ /// \param [in,out] UnsignedVec - Vector of unsigned integers to append to.
+ void convertToUnsignedVec(BasicBlock &BB,
+ std::vector<IRInstructionData *> &InstrList,
----------------
The `UnsignedVec` name here conveys what it is, but that's the same as its type... maybe there's a better name that says more about what it does? ValueNumbering? InstNumbering?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86968/new/
https://reviews.llvm.org/D86968
More information about the llvm-commits
mailing list