[PATCH] D87468: [Support] Add GlobPattern::isTrivialMatchAll()

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/unittests/Support/GlobPatternTest.cpp:141
+  EXPECT_TRUE(Pat1->isTrivialMatchAll());
+  Expected<GlobPattern> Pat2 = GlobPattern::create("a*");
+  EXPECT_TRUE((bool)Pat2);
----------------
MaskRay wrote:
> Most patterns are expected to return false.
> 
> The negative patterns can be organized as a const char * array to improve readability
You don't need ` EXPECT_TRUE((bool)Pat2);` because it is implied by the following `Pat2->`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87468/new/

https://reviews.llvm.org/D87468