[PATCH] D87468: [Support] Add GlobPattern::isTrivialMatchAll()

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 14 17:26:44 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/unittests/Support/GlobPatternTest.cpp:141
+  EXPECT_TRUE(Pat1->isTrivialMatchAll());
+  Expected<GlobPattern> Pat2 = GlobPattern::create("a*");
+  EXPECT_TRUE((bool)Pat2);
----------------
Most patterns are expected to return false.

The negative patterns can be organized as a const char * array to improve readability


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87468/new/

https://reviews.llvm.org/D87468



More information about the llvm-commits mailing list