[PATCH] D84544: [ConstraintSystem] Add helpers to deal with linear constraints.

Sun Sep 13 13:23:43 PDT 2020

fhahn added a comment.

In D84544#2270210 <https://reviews.llvm.org/D84544#2270210>, @steakhal wrote:

> I'm curious if we could make use of this in the Clang Static Analyzer.
> We always hit the limitations of the current Constraint manager implementation.
> What do you think about this @NoQ @xazax.hun @Szelethus?

It would be great if this would be useful for other users as well! It is intended as relatively generic utility and I would be more than happy to collaborate/coordinate to make sure it works well for additional uses cases.

Please note that there is plenty of potential for additional improvements in the code. The aim is to get started with a relatively simple implementation and an initial user so there is decent test coverage as we work on improving both.

================
Comment at: llvm/lib/Analysis/ConstraintSystem.cpp:137
+bool ConstraintSystem::mayHaveSolution() {
+  dump();
+  bool HasSolution = mayHaveSolutionImpl();
----------------
steakhal wrote:
> Is this unconditional dump intentional?
`dump` only generates output with `-debug`. It might be worth to make this more explicit here, but I am not sure what the best way would be.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84544/new/

https://reviews.llvm.org/D84544