[PATCH] D84545: [ConstraintSolver] Add isConditionImplied helper.
    Sanjay Patel via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Sep  8 09:54:28 PDT 2020
    
    
  
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Analysis/ConstraintSystem.cpp:149
+  // If there is no solution with the negation of R added to the system, the
+  // condition must hold based on the exsisting constraints.
+  R = ConstraintSystem::negate(R);
----------------
Typo - existing
================
Comment at: llvm/unittests/Analysis/ConstraintSystemTest.cpp:83
+
+TEST(ConstraintSloverTest, IsConditionImplied) {
+  {
----------------
Typo: Slover -> Solver
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84545/new/
https://reviews.llvm.org/D84545
    
    
More information about the llvm-commits
mailing list