[PATCH] D87351: AMDGPU/GlobalISel/Emitter Recognize additional 'same operand checks'

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-fract.f64.mir:27-28
     ; CHECK: [[COPY4:%[0-9]+]]:vreg_64 = COPY [[S_LOAD_DWORDX2_IMM]]
     ; CHECK: %12:vreg_64 = nofpexcept V_ADD_F64 0, [[COPY3]], 1, [[COPY4]], 0, 0, implicit $mode, implicit $exec
-    ; CHECK: %13:vreg_64 = nofpexcept V_FLOOR_F64_e64 0, %12, 0, 0, implicit $mode, implicit $exec
-    ; CHECK: %15:vreg_64 = nofpexcept V_ADD_F64 0, %12, 1, %13, 0, 0, implicit $mode, implicit $exec
+    ; CHECK: %15:vreg_64 = nofpexcept V_FRACT_F64_e64 0, %12, 0, 0, implicit $mode, implicit $exec
     ; CHECK: [[COPY5:%[0-9]+]]:vreg_64 = COPY [[COPY1]]
----------------
Petar.Avramovic wrote:
> arsenm wrote:
> > Is this pattern really correct? It should probably be moved into a combine instead of a selection pattern if so
> It is correctly selected  since -enable-unsafe-fp-math flag was on.
I think this should be moved into a combine and not depend on the global flag, but that's a separate change


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87351/new/

https://reviews.llvm.org/D87351