[PATCH] D87453: [llvm-readobj/elf][test] - Test all core note types properly.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D87453#2266628 <https://reviews.llvm.org/D87453#2266628>, @MaskRay wrote:

> Emm. I am a bit less sure about the value enumerating every value. It just repeats the getCoreNoteTypeName list in the test file. Two or three values should work, right?

I believe all values should be tested at least somewhere. We had a situation previously (for file format names) where we tested all values in `lib/Object` unit test (ELFObjectFileTest.cpp)
and that allowed use to test just a few values in `llvm-readelf` test. But this case is different - note types are defined in llvm-readelf code.

This is the same what we do for other things. E.g. we normally test all possible relocations, dynamic tags, etc.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87453/new/

https://reviews.llvm.org/D87453