[PATCH] D87453: [llvm-readobj/elf][test] - Test all core note types properly.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 13:24:15 PDT 2020


MaskRay added a comment.

Emm. I am a bit less sure about the value enumerating every value. It just repeats the getCoreNoteTypeName list in the test file. Two or three values should work, right?



================
Comment at: llvm/test/tools/llvm-readobj/ELF/note-core.test:3
 
-# RUN: yaml2obj %s -o %t.o
-# RUN: llvm-readelf --notes %t.o | FileCheck %s --check-prefix=GNU
-# RUN: llvm-readobj --notes %t.o | FileCheck %s --check-prefix=LLVM
+## Check NT_PRSTATUS
+# RUN: yaml2obj %s -DTYPE=0x1 -o %t1.o
----------------
Not consistent with other `Check ` where a period is present


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87453/new/

https://reviews.llvm.org/D87453



More information about the llvm-commits mailing list