[PATCH] D87161: [DemandedBits][BDCE] Add support for min/max intrinsics

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 13:14:54 PDT 2020


nikic marked an inline comment as done.
nikic added inline comments.


================
Comment at: llvm/lib/Analysis/DemandedBits.cpp:181-182
+        break;
       }
     break;
   case Instruction::Add:
----------------
spatel wrote:
> Nit: this is where LLVM formatting rules break down. I couldn't tell that we were in a switch-within-an-if-within-a-swich from that single brace/indent. At the least, I'd add braces on the 'if'. 
Agreed. I've added braces for the if in a separate commit: https://github.com/llvm/llvm-project/commit/99e78cb7185db1a15afd33020a1e026dc7ac5e1b


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87161/new/

https://reviews.llvm.org/D87161



More information about the llvm-commits mailing list