[llvm] 601557e - Hexagon.h - remove unnecessary includes. NFCI.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 10 09:51:05 PDT 2020
A mixture of ClangBuildAnalyzer (which highlights the most expensive
headers), cppclean and IncludeToolbox (a VS include-what-you-use wrapper
tool) - none of which are particularly reliable so a lot of manual
inspection is still required.
Since lockdown led me to using my ancient home machines a lot more for
development I've been "motivated" to reduce the build time of llvm.......
On 10/09/2020 17:02, Krzysztof Parzyszek wrote:
> Thanks! How are you finding these?
>
> --
> Krzysztof Parzyszek kparzysz at quicinc.com AI tools development
>
> -----Original Message-----
> From: llvm-commits <llvm-commits-bounces at lists.llvm.org> On Behalf Of Simon Pilgrim via llvm-commits
> Sent: Thursday, September 10, 2020 11:00 AM
> To: llvm-commits at lists.llvm.org
> Subject: [EXT] [llvm] 601557e - Hexagon.h - remove unnecessary includes. NFCI.
>
>
> Author: Simon Pilgrim
> Date: 2020-09-10T16:59:43+01:00
> New Revision: 601557e9f9e829e5a798a1dbb6b46a98c8fb7810
>
> URL: https://github.com/llvm/llvm-project/commit/601557e9f9e829e5a798a1dbb6b46a98c8fb7810
> DIFF: https://github.com/llvm/llvm-project/commit/601557e9f9e829e5a798a1dbb6b46a98c8fb7810.diff
>
> LOG: Hexagon.h - remove unnecessary includes. NFCI.
>
> Replace with forward declarations and move includes to implicit dependent files.
>
> Added:
>
>
> Modified:
> llvm/lib/Target/Hexagon/Hexagon.h
> llvm/lib/Target/Hexagon/HexagonCFGOptimizer.cpp
> llvm/lib/Target/Hexagon/HexagonCopyToCombine.cpp
> llvm/lib/Target/Hexagon/HexagonFrameLowering.h
> llvm/lib/Target/Hexagon/HexagonISelLowering.h
> llvm/lib/Target/Hexagon/HexagonOptimizeSZextends.cpp
> llvm/lib/Target/Hexagon/HexagonSubtarget.cpp
>
> Removed:
>
>
>
> ################################################################################
> diff --git a/llvm/lib/Target/Hexagon/Hexagon.h b/llvm/lib/Target/Hexagon/Hexagon.h
> index 58dadf012da5..98e5710d4fc1 100644
> --- a/llvm/lib/Target/Hexagon/Hexagon.h
> +++ b/llvm/lib/Target/Hexagon/Hexagon.h
> @@ -14,12 +14,9 @@
> #ifndef LLVM_LIB_TARGET_HEXAGON_HEXAGON_H #define LLVM_LIB_TARGET_HEXAGON_HEXAGON_H
>
> -#include "MCTargetDesc/HexagonMCTargetDesc.h"
> -#include "llvm/CodeGen/TargetLowering.h"
> -#include "llvm/Target/TargetMachine.h"
> -
> namespace llvm {
> class HexagonTargetMachine;
> + class ImmutablePass;
>
> /// Creates a Hexagon-specific Target Transformation Info pass.
> ImmutablePass *createHexagonTargetTransformInfoPass(const HexagonTargetMachine *TM);
>
> diff --git a/llvm/lib/Target/Hexagon/HexagonCFGOptimizer.cpp b/llvm/lib/Target/Hexagon/HexagonCFGOptimizer.cpp
> index 11a455ce4347..b456cf139c55 100644
> --- a/llvm/lib/Target/Hexagon/HexagonCFGOptimizer.cpp
> +++ b/llvm/lib/Target/Hexagon/HexagonCFGOptimizer.cpp
> @@ -7,6 +7,7 @@
> //===----------------------------------------------------------------------===//
>
> #include "Hexagon.h"
> +#include "MCTargetDesc/HexagonMCTargetDesc.h"
> #include "llvm/CodeGen/MachineBasicBlock.h"
> #include "llvm/CodeGen/MachineBranchProbabilityInfo.h"
> #include "llvm/CodeGen/MachineFunction.h"
>
> diff --git a/llvm/lib/Target/Hexagon/HexagonCopyToCombine.cpp b/llvm/lib/Target/Hexagon/HexagonCopyToCombine.cpp
> index 587527d8c32c..23d0cc829e52 100644
> --- a/llvm/lib/Target/Hexagon/HexagonCopyToCombine.cpp
> +++ b/llvm/lib/Target/Hexagon/HexagonCopyToCombine.cpp
> @@ -10,6 +10,7 @@
> // to move them together. If we can move them next to each other we do so and // replace them with a combine instruction.
> //===----------------------------------------------------------------------===//
> +
> #include "HexagonInstrInfo.h"
> #include "HexagonSubtarget.h"
> #include "llvm/ADT/DenseMap.h"
> @@ -26,6 +27,7 @@
> #include "llvm/Support/CommandLine.h"
> #include "llvm/Support/Debug.h"
> #include "llvm/Support/raw_ostream.h"
> +#include "llvm/Target/TargetMachine.h"
>
> using namespace llvm;
>
>
> diff --git a/llvm/lib/Target/Hexagon/HexagonFrameLowering.h b/llvm/lib/Target/Hexagon/HexagonFrameLowering.h
> index 87d385e1ce3c..c8871cc56c48 100644
> --- a/llvm/lib/Target/Hexagon/HexagonFrameLowering.h
> +++ b/llvm/lib/Target/Hexagon/HexagonFrameLowering.h
> @@ -11,6 +11,7 @@
>
> #include "Hexagon.h"
> #include "HexagonBlockRanges.h"
> +#include "MCTargetDesc/HexagonMCTargetDesc.h"
> #include "llvm/ADT/STLExtras.h"
> #include "llvm/CodeGen/MachineBasicBlock.h"
> #include "llvm/CodeGen/MachineFrameInfo.h"
>
> diff --git a/llvm/lib/Target/Hexagon/HexagonISelLowering.h b/llvm/lib/Target/Hexagon/HexagonISelLowering.h
> index 9e7176cd9421..a396ff8ef7ec 100644
> --- a/llvm/lib/Target/Hexagon/HexagonISelLowering.h
> +++ b/llvm/lib/Target/Hexagon/HexagonISelLowering.h
> @@ -15,6 +15,7 @@
> #define LLVM_LIB_TARGET_HEXAGON_HEXAGONISELLOWERING_H
>
> #include "Hexagon.h"
> +#include "MCTargetDesc/HexagonMCTargetDesc.h"
> #include "llvm/ADT/StringRef.h"
> #include "llvm/CodeGen/ISDOpcodes.h"
> #include "llvm/CodeGen/SelectionDAGNodes.h"
>
> diff --git a/llvm/lib/Target/Hexagon/HexagonOptimizeSZextends.cpp b/llvm/lib/Target/Hexagon/HexagonOptimizeSZextends.cpp
> index d818e0897f75..e026bb6d601d 100644
> --- a/llvm/lib/Target/Hexagon/HexagonOptimizeSZextends.cpp
> +++ b/llvm/lib/Target/Hexagon/HexagonOptimizeSZextends.cpp
> @@ -11,7 +11,9 @@
> //
> //===----------------------------------------------------------------------===//
>
> +#include "Hexagon.h"
> #include "llvm/CodeGen/StackProtector.h"
> +#include "llvm/CodeGen/ValueTypes.h"
> #include "llvm/IR/Function.h"
> #include "llvm/IR/Instructions.h"
> #include "llvm/IR/IntrinsicInst.h"
> @@ -19,8 +21,6 @@
> #include "llvm/Pass.h"
> #include "llvm/Transforms/Scalar.h"
>
> -#include "Hexagon.h"
> -
> using namespace llvm;
>
> namespace llvm {
>
> diff --git a/llvm/lib/Target/Hexagon/HexagonSubtarget.cpp b/llvm/lib/Target/Hexagon/HexagonSubtarget.cpp
> index b1d06b0c3937..60792929be91 100644
> --- a/llvm/lib/Target/Hexagon/HexagonSubtarget.cpp
> +++ b/llvm/lib/Target/Hexagon/HexagonSubtarget.cpp
> @@ -10,10 +10,10 @@
> //
> //===----------------------------------------------------------------------===//
>
> +#include "HexagonSubtarget.h"
> #include "Hexagon.h"
> #include "HexagonInstrInfo.h"
> #include "HexagonRegisterInfo.h"
> -#include "HexagonSubtarget.h"
> #include "MCTargetDesc/HexagonMCTargetDesc.h"
> #include "llvm/ADT/STLExtras.h"
> #include "llvm/ADT/SmallSet.h"
> @@ -26,6 +26,7 @@
> #include "llvm/CodeGen/ScheduleDAGInstrs.h"
> #include "llvm/Support/CommandLine.h"
> #include "llvm/Support/ErrorHandling.h"
> +#include "llvm/Target/TargetMachine.h"
> #include <algorithm>
> #include <cassert>
> #include <map>
> @@ -38,7 +39,6 @@ using namespace llvm;
> #define GET_SUBTARGETINFO_TARGET_DESC
> #include "HexagonGenSubtargetInfo.inc"
>
> -
> static cl::opt<bool> EnableBSBSched("enable-bsb-sched",
> cl::Hidden, cl::ZeroOrMore, cl::init(true));
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list