[PATCH] D86814: [DebugInstrRef][3/3] Follow DBG_PHI instructions through LiveDebugValues.

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 10 09:01:34 PDT 2020


jmorse updated this revision to Diff 290994.
jmorse added a comment.

Address the loop matter I mention at the end of the review summary -- I've convinced myself that we only need to validate very simple loops in this context, because LLVMs tail-duplicator doesn't substantially rewrite functions, it only duplicates bits of it.

I've added an extra test for finding the value of DBG_PHIs even if there's a loop in between the DBG_PHIs and their uses.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86814/new/

https://reviews.llvm.org/D86814

Files:
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-in-ldv.mir
  llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-merging-in-ldv.mir
  llvm/test/DebugInfo/MIR/InstrRef/dbg-phis-with-loops.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D86814.290994.patch
Type: text/x-patch
Size: 52097 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200910/f310716a/attachment-0001.bin>


More information about the llvm-commits mailing list