[PATCH] D87429: [obj2yaml] Add support for dumping the .debug_ranges section.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nits.



================
Comment at: llvm/test/tools/obj2yaml/ELF/DWARF/debug-ranges.yaml:97
+  ## The debug_ranges parser depends on the address_size field
+  ## of compilation units. We should add the .debug_info section
+  ## to assist the parser.
----------------
No need for the "should". Hard to explain from a grammatical perspective though!


================
Comment at: llvm/test/tools/obj2yaml/ELF/DWARF/debug-ranges.yaml:150
+# RUN: yaml2obj --docnum=2 %s | obj2yaml | \
+# RUN:   FileCheck %s --check-prefix=EMPTY --implicit-check-not=Sections
+
----------------
This should be less brittle in case any user paths start appearing in the output at some point.


================
Comment at: llvm/test/tools/obj2yaml/ELF/DWARF/debug-ranges.yaml:85
+##                           ^--------------- LowOffset
+#      RAW:                  2000000000000000
+##                           ^--------------- HighOffset
----------------
Higuoxing wrote:
> jhenderson wrote:
> > This and the following lines probably want to be RAW-SAME, and start with a `{{$}}` to ensure there's nothing in between the previous match and the checked-for one.
> It looks that `FileCheck` is not happy when the check line starts with a `{{$}}`. I think using `{{^}}` to check that the rest buffer exactly starts with our check string is fine here. What do you think?
Sorry, `{{^}}` was what I meant (I got mixed up between start and end of line regex).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87429/new/

https://reviews.llvm.org/D87429