[PATCH] D87429: [obj2yaml] Add support for dumping the .debug_ranges section.
Xing GUO via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 10 02:09:10 PDT 2020
Higuoxing added inline comments.
================
Comment at: llvm/test/tools/obj2yaml/ELF/DWARF/debug-ranges.yaml:85
+## ^--------------- LowOffset
+# RAW: 2000000000000000
+## ^--------------- HighOffset
----------------
jhenderson wrote:
> This and the following lines probably want to be RAW-SAME, and start with a `{{$}}` to ensure there's nothing in between the previous match and the checked-for one.
It looks that `FileCheck` is not happy when the check line starts with a `{{$}}`. I think using `{{^}}` to check that the rest buffer exactly starts with our check string is fine here. What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87429/new/
https://reviews.llvm.org/D87429
More information about the llvm-commits
mailing list