[PATCH] D87045: [LoopNest] Handle loop-nest passes in LoopPassManager
Yuanfang Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 9 12:55:18 PDT 2020
ychen added a comment.
- How about using `PreservedAnalyses run(Loop &, LoopAnalysisManager &, LoopStandardAnalysisResults &, LPMUpdater &, LoopNest &);` for the interface. I think it should work better because it is still a loop pass interface.
- Add a test case for PassInstrument?
================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:67
+
+// SFINAE helper class that distinguish loop passes and loop-nest passes.
+template <typename PassT, typename SFINAE = void>
----------------
There is `is_detected` in STLExtras.h that could simplify this. It is fine putting this in the PassManager itself.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87045/new/
https://reviews.llvm.org/D87045
More information about the llvm-commits
mailing list