[PATCH] D87045: [LoopNest] Handle loop-nest passes in LoopPassManager

[Whitney Tsang via Phabricator via llvm-commits]

Whitney added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:177
+  // passes (true for loop-nest passes).
+  BitVector PassCategories;
+  std::vector<std::unique_ptr<LoopPassConceptT>> LoopPasses;
----------------
Do you think is a good idea to rename `PassCategories` to `IsLoopNestPass`?


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:178
+  BitVector PassCategories;
+  std::vector<std::unique_ptr<LoopPassConceptT>> LoopPasses;
+  std::vector<std::unique_ptr<LoopNestPassConceptT>> LoopNestPasses;
----------------
can we use llvm data structures here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87045/new/

https://reviews.llvm.org/D87045