[PATCH] D87232: [SVE][CodeGen] Lower floating point -> integer conversions

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12332-12334
+  return DAG.getNode(Opc, DL, ConvertVT,
+                     DAG.getUNDEF(ConvertVT),
+                     Pred, VecToConvert);
----------------
This doesn't look correct.  You are dropping the passthru value (i.e. Operand(1)) and always using UNDEF instead.  It's a bit troubling that such a change hasn't broken any of the lit tests.

I think you'll want to treat these like the other unary operations, which have matching _MERGE_PASSTHRU ISD nodes rather than _PRED ones.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87232/new/

https://reviews.llvm.org/D87232